Bug 158041

Summary: We Should be able to use the sampling profiler with DRT/WTR.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Keith Miller 2016-05-24 15:03:20 PDT 
We Should be able to use the sampling profiler with DRT/WTR.
Comment 1 Keith Miller 2016-05-24 15:18:12 PDT 
Created attachment 279711 [details]
Patch
Comment 2 Saam Barati 2016-05-24 15:24:48 PDT 
Comment on attachment 279711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279711&action=review

r=me with comments

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:767
> +    static HashSet<SamplingProfiler*>* profilesToReport;

You can just do HashSet<RefPtr<SamplingProfiler>> instead of manually ref()ing.

> Source/JavaScriptCore/runtime/SamplingProfiler.h:180
> +    bool m_needsReportAtExit;

This should default to sing false.
Comment 3 Saam Barati 2016-05-24 15:27:49 PDT 
Comment on attachment 279711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279711&action=review

>> Source/JavaScriptCore/runtime/SamplingProfiler.h:180
>> +    bool m_needsReportAtExit;
> 
> This should default to sing false.

being*
Comment 4 Keith Miller 2016-05-24 15:33:02 PDT 
Created attachment 279713 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-05-24 16:02:02 PDT 
Comment on attachment 279713 [details]
Patch for landing

Clearing flags on attachment: 279713

Committed r201361: <http://trac.webkit.org/changeset/201361>
Comment 6 WebKit Commit Bot 2016-05-24 16:02:06 PDT 
All reviewed patches have been landed.  Closing bug.