Bug 158014

Summary: [JSC][DOM] Always pass receiver and slotBase to custom (value/accessor) getter
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED WONTFIX    
Severity: Normal CC: sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216533

Description Yusuke Suzuki 2016-05-23 22:41:52 PDT
Currently, custom value getter receives slotBase as the second argument, but custom accessor getter takes the receiver as the second argument.
We should unify this behavior.
Comment 1 Sam Weinig 2017-04-25 18:29:19 PDT
I've lost track of the terminology. What are "custom value getters" and what are "custom accessor getters"?  Do we use both for the DOM?
Comment 2 Yusuke Suzuki 2017-04-25 23:26:45 PDT
(In reply to Sam Weinig from comment #1)
> I've lost track of the terminology. What are "custom value getters" and what
> are "custom accessor getters"?  Do we use both for the DOM?

The custom value getters are shown as usual value from the user. But internally it invokes a custom function.
The custom accessor getter is shown as a JS accessor which invokes a custom function.

After considering this, I think now it is not necessary.
It is better to leave the current one since

1. All the current custom accessor just requires this value. Previously ES6 Proxy was an exception. But now the design is changed and it is not necessary.
2. All the current custom value accessor requires slot base.