Bug 157992

Summary: Need SPI for clients to require a user action to get an editing controls manager
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, sam, thorton
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Beth Dakin 2016-05-23 12:16:05 PDT
Need SPI for clients to require a user action to get an editing controls manager

rdar://problem/26379927
Comment 1 Beth Dakin 2016-05-23 12:33:59 PDT
Created attachment 279575 [details]
Patch
Comment 2 Tim Horton 2016-05-23 14:44:27 PDT
Comment on attachment 279575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279575&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:683
> +- (BOOL)_requiresUserActionForEditingControlsManager

I would drop at *least* the "manager" from this name. Maybe see if Anders can come up with a better name?
Comment 3 Beth Dakin 2016-05-23 15:06:44 PDT
http://trac.webkit.org/changeset/201298

Thanks Tim!