Bug 157951

Summary:

JSBench regression: CodeBlock linking always copies the symbol table

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+

Description Geoffrey Garen 2016-05-20 11:53:50 PDT

JSBench regression: CodeBlock linking always copies the symbol table

Comment 1 Geoffrey Garen 2016-05-20 11:55:46 PDT

Created attachment 279493 [details]
Patch

Comment 2 Saam Barati 2016-05-20 11:59:05 PDT

Comment on attachment 279493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279493&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1673
> +        ASSERT(var.symbolTableConstantIndex());

Style: I think its nicer to put asserts validating inputs before we assign something to the input.

Comment 3 Geoffrey Garen 2016-05-20 12:12:00 PDT

Committed r201221: <http://trac.webkit.org/changeset/201221>