Bug 157943

Summary: Small improvements to RenderBox/LayoutUnit casting in MathML
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, mrobinson, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 153208, 153742, 153917    
Bug Blocks:    
Attachments:
Description Flags
Patch darin: review+

Frédéric Wang (:fredw)
Reported 2016-05-20 06:16:18 PDT
This is a small follow-up of the ​RenderMathMLRow/​RenderMathMLUnderOver/​RenderMathMLFraction refactoring. Since these MathML renderers can only contain other MathML renderers, we can just considerer RenderBox children and prevent unnecessary casts. Similarly, when the two arguments of std::max are LayoutUnit's, we do not need to specialize to std::max<LayoutUnit>.
Attachments
Patch (5.97 KB, patch)
2016-05-20 06:23 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-05-20 06:23:50 PDT
Created attachment 279480 [details] Patch
Darin Adler
Comment 2 2016-05-24 09:03:02 PDT
Comment on attachment 279480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279480&action=review > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:58 > + RenderBox* base = firstChildBox(); Typically in new code, we would use auto* here instead of writing RenderBox*. > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:78 > + for (RenderBox* child = firstChildBox(); child; child = child->nextSiblingBox()) { Ditto.
Frédéric Wang (:fredw)
Comment 3 2016-05-26 02:16:18 PDT
https://trac.webkit.org/changeset/201418
Note You need to log in before you can comment on or make changes to this bug.