Bug 157932

Summary: Web Inspector: Visual Style connectors are not always centered properly
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, hi, joepeck, jond, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-05-19 16:32:07 PDT
* SUMMARY Visual Style connectors are not always centered properly. - All the time, the top and bottom connectors are different distances from the center connector - At some widths, the middle connector is off-center from the others
Attachments
[PATCH] Proposed Fix (2.15 KB, patch)
2016-05-19 16:34 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[IMAGE] Before (28.27 KB, image/png)
2016-05-19 16:36 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (28.06 KB, image/png)
2016-05-19 16:37 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (2.16 KB, patch)
2016-05-19 17:06 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-19 16:33:00 PDT
<rdar://problem/26380629>
Joseph Pecoraro
Comment 2 2016-05-19 16:34:18 PDT
Created attachment 279446 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-05-19 16:36:36 PDT
Created attachment 279447 [details] [IMAGE] Before
Joseph Pecoraro
Comment 4 2016-05-19 16:37:05 PDT
Created attachment 279448 [details] [IMAGE] After
Joseph Pecoraro
Comment 5 2016-05-19 16:40:16 PDT
Comment on attachment 279446 [details] [PATCH] Proposed Fix The margin-left: 1px may be needed for non-Retina.
Joseph Pecoraro
Comment 6 2016-05-19 17:06:11 PDT
Created attachment 279455 [details] [PATCH] Proposed Fix Tested on @1x and @2x.
WebKit Commit Bot
Comment 7 2016-05-19 21:12:31 PDT
Comment on attachment 279455 [details] [PATCH] Proposed Fix Clearing flags on attachment: 279455 Committed r201209: <http://trac.webkit.org/changeset/201209>
WebKit Commit Bot
Comment 8 2016-05-19 21:12:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.