Summary: | Drag cannot start if no drag data or custom data is available in the Pasteboard | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||||||||||||||
Component: | WebKit Misc. | Assignee: | Enrica Casucci <enrica> | ||||||||||||||||
Status: | REOPENED --- | ||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, rniwa, sam, thorton | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | Other | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Enrica Casucci
2016-05-19 12:30:35 PDT
Created attachment 279410 [details]
Patch
Attachment 279410 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2946: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 279410 [details] Patch Attachment 279410 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1349587 New failing tests: inspector/debugger/scriptParsed.html Created attachment 279419 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 279410 [details] Patch Attachment 279410 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1349590 New failing tests: fast/events/draggable-div-nodata.html Created attachment 279420 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 279410 [details] Patch Attachment 279410 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1349586 New failing tests: fast/events/draggable-div-nodata.html Created attachment 279423 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 279410 [details]
Patch
Looks fine but please fix the test.
Updated TestExpectations for iOS-simulator and WK2 mac before landing. Committed revision 201189. Reopening since we found an issue with the fix. Created attachment 279495 [details]
Patch2
Comment on attachment 279495 [details] Patch2 Attachment 279495 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1355123 New failing tests: fast/events/draggable-div-customdata.html Created attachment 279499 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 279495 [details] Patch2 Attachment 279495 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1355196 New failing tests: fast/events/draggable-div-customdata.html Created attachment 279500 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
|