Bug 157911 - Drag cannot start if no drag data or custom data is available in the Pasteboard
Summary: Drag cannot start if no drag data or custom data is available in the Pasteboard
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-19 12:30 PDT by Enrica Casucci
Modified: 2016-05-20 14:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.43 KB, patch)
2016-05-19 12:34 PDT, Enrica Casucci
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (797.77 KB, application/zip)
2016-05-19 13:21 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (805.25 KB, application/zip)
2016-05-19 13:24 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (706.17 KB, application/zip)
2016-05-19 13:28 PDT, Build Bot
no flags Details
Patch2 (7.22 KB, patch)
2016-05-20 12:35 PDT, Enrica Casucci
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.03 MB, application/zip)
2016-05-20 13:06 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (648.22 KB, application/zip)
2016-05-20 13:29 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-05-19 12:30:35 PDT
We should be able to do custom drag-and-drop even without placing data in the pasteboard.
Having data in the pasteboard is now required by AppKit.

rdar://problem/24577706
Comment 1 Enrica Casucci 2016-05-19 12:34:55 PDT
Created attachment 279410 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-19 12:37:50 PDT
Attachment 279410 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2946:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2016-05-19 13:21:32 PDT
Comment on attachment 279410 [details]
Patch

Attachment 279410 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1349587

New failing tests:
inspector/debugger/scriptParsed.html
Comment 4 Build Bot 2016-05-19 13:21:34 PDT
Created attachment 279419 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-05-19 13:24:02 PDT
Comment on attachment 279410 [details]
Patch

Attachment 279410 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1349590

New failing tests:
fast/events/draggable-div-nodata.html
Comment 6 Build Bot 2016-05-19 13:24:04 PDT
Created attachment 279420 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-05-19 13:28:50 PDT
Comment on attachment 279410 [details]
Patch

Attachment 279410 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1349586

New failing tests:
fast/events/draggable-div-nodata.html
Comment 8 Build Bot 2016-05-19 13:28:52 PDT
Created attachment 279423 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 9 Tim Horton 2016-05-19 14:03:09 PDT
Comment on attachment 279410 [details]
Patch

Looks fine but please fix the test.
Comment 10 Enrica Casucci 2016-05-19 15:19:31 PDT
Updated TestExpectations for iOS-simulator and WK2 mac before landing.
Committed revision 201189.
Comment 11 Enrica Casucci 2016-05-20 11:45:34 PDT
Reopening since we found an issue with the fix.
Comment 12 Enrica Casucci 2016-05-20 12:35:44 PDT
Created attachment 279495 [details]
Patch2
Comment 13 Build Bot 2016-05-20 13:06:00 PDT
Comment on attachment 279495 [details]
Patch2

Attachment 279495 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1355123

New failing tests:
fast/events/draggable-div-customdata.html
Comment 14 Build Bot 2016-05-20 13:06:03 PDT
Created attachment 279499 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-05-20 13:29:25 PDT
Comment on attachment 279495 [details]
Patch2

Attachment 279495 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1355196

New failing tests:
fast/events/draggable-div-customdata.html
Comment 16 Build Bot 2016-05-20 13:29:28 PDT
Created attachment 279500 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4