Bug 157911 – Drag cannot start if no drag data or custom data is available in the Pasteboard

• Status: REOPENED
• Component: WebKit Misc.

[Enrica Casucci]

We should be able to do custom drag-and-drop even without placing data in the pasteboard.
Having data in the pasteboard is now required by AppKit.

rdar://problem/24577706

[Enrica Casucci]

Created attachment 279410 [details]
Patch

[WebKit Commit Bot]

Attachment 279410 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2946:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 279410 [details]
Patch

Attachment 279410 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1349587

New failing tests:
inspector/debugger/scriptParsed.html

[Build Bot]

Created attachment 279419 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279410 [details]
Patch

Attachment 279410 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1349590

New failing tests:
fast/events/draggable-div-nodata.html

[Build Bot]

Created attachment 279420 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279410 [details]
Patch

Attachment 279410 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1349586

New failing tests:
fast/events/draggable-div-nodata.html

[Build Bot]

Created attachment 279423 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Tim Horton]

Comment on attachment 279410 [details]
Patch

Looks fine but please fix the test.

[Enrica Casucci]

Updated TestExpectations for iOS-simulator and WK2 mac before landing.
Committed revision 201189.

[Enrica Casucci]

Reopening since we found an issue with the fix.

[Enrica Casucci]

Created attachment 279495 [details]
Patch2

[Build Bot]

Comment on attachment 279495 [details]
Patch2

Attachment 279495 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1355123

New failing tests:
fast/events/draggable-div-customdata.html

[Build Bot]

Created attachment 279499 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279495 [details]
Patch2

Attachment 279495 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1355196

New failing tests:
fast/events/draggable-div-customdata.html

[Build Bot]

Created attachment 279500 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4