Bug 157910

Summary: Web Inspector: Split Console is auto opening all the time when using Inspect Element context menu
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
timothy: review+
Patch
none
Patch none

Timothy Hatcher
Reported 2016-05-19 12:20:43 PDT
This might be happening because the Inspected Element auto logging? It is getting annoying!
Attachments
Patch (1.90 KB, patch)
2016-05-19 15:06 PDT, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
Patch (9.97 KB, patch)
2016-05-20 11:40 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (10.07 KB, patch)
2016-05-20 11:42 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-19 12:24:53 PDT
<rdar://problem/26374066>
Nikita Vasilyev
Comment 2 2016-05-19 15:06:08 PDT
Created attachment 279438 [details] Patch
Timothy Hatcher
Comment 3 2016-05-19 15:08:59 PDT
Comment on attachment 279438 [details] Patch I think this will cause the split console to not open for things like "Log Object" in the heap snapshot. Joe?
Joseph Pecoraro
Comment 4 2016-05-19 15:28:28 PDT
Comment on attachment 279438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279438&action=review > Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:273 > // We only auto show the console if the message is a non-synthetic result. > // This is when the user evaluated something directly in the prompt. Right now "synthetic" means "token". It does not mean frontend added. If we want to distinguish between frontend added immediately evaluations (Log Value and Inspect Element) you would want a new state to work with.
Nikita Vasilyev
Comment 5 2016-05-20 11:40:51 PDT
Created attachment 279491 [details] Patch
Nikita Vasilyev
Comment 6 2016-05-20 11:42:12 PDT
Created attachment 279492 [details] Patch
WebKit Commit Bot
Comment 7 2016-05-20 12:34:59 PDT
Comment on attachment 279492 [details] Patch Clearing flags on attachment: 279492 Committed r201222: <http://trac.webkit.org/changeset/201222>
WebKit Commit Bot
Comment 8 2016-05-20 12:35:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.