Bug 157904

Summary: Web Inspector: Snapshot List should show the total size and the total live size
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 158973    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Live Size Column none

Joseph Pecoraro
Reported 2016-05-19 11:34:11 PDT
* SUMMARY Snapshot List should show the total size and the total live size. As objects go away, it would be nice to show just the total live size, so you can see just the growth.
Attachments
[PATCH] Proposed Fix (14.00 KB, patch)
2016-06-20 16:28 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Live Size Column (122.18 KB, image/png)
2016-06-20 16:31 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-19 11:35:30 PDT
<rdar://problem/26372833>
Joseph Pecoraro
Comment 2 2016-06-20 16:28:53 PDT
Created attachment 281684 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-06-20 16:31:05 PDT
Created attachment 281685 [details] [IMAGE] Live Size Column Example page doesn't really leak, it just creates a lot of objects in between takeHeapSnapshot("before") and "after" that will get collected. The "after" correctly shows lots of objects, but after they get collected and another snapshot is taken, the live size updates.
Blaze Burg
Comment 4 2016-06-20 16:33:41 PDT
Comment on attachment 281684 [details] [PATCH] Proposed Fix r=me
Blaze Burg
Comment 5 2016-06-20 16:35:38 PDT
(In reply to comment #3) > Created attachment 281685 [details] > [IMAGE] Live Size Column > > Example page doesn't really leak, it just creates a lot of objects in > between takeHeapSnapshot("before") and "after" that will get collected. The > "after" correctly shows lots of objects, but after they get collected and > another snapshot is taken, the live size updates. This would be a big improvement for the WWDC demo, where it's not entirely clear what portion of the snapshot size growth is actually leak vs. slow churn of large objects.
WebKit Commit Bot
Comment 6 2016-06-20 17:01:42 PDT
Comment on attachment 281684 [details] [PATCH] Proposed Fix Clearing flags on attachment: 281684 Committed r202253: <http://trac.webkit.org/changeset/202253>
WebKit Commit Bot
Comment 7 2016-06-20 17:01:46 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2016-06-20 20:08:15 PDT
This broke a test: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Funit-tests%2Fheap-snapshot-collection-event.html +!! EXCEPTION: snapshot.updateCategories is not a function. (In 'snapshot.updateCategories', 'snapshot.updateCategories' is undefined) Both this test and inspector/unit-tests/heap-snapshot.html were already very flaky, but this was definitely a regression.
WebKit Commit Bot
Comment 9 2016-06-20 20:10:29 PDT
Re-opened since this is blocked by bug 158973
Joseph Pecoraro
Comment 10 2016-06-20 20:23:56 PDT
(In reply to comment #9) > Re-opened since this is blocked by bug 158973 Closing, since we fixed the test instead of rolling out. <https://trac.webkit.org/changeset/202264>
Note You need to log in before you can comment on or make changes to this bug.