Bug 157871

Summary: Make LayoutUnit::operator bool() explicit.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2016-05-18 16:26:44 PDT
This is in preparation to get LayoutUnit operator int() removed.
Attachments
Patch (2.19 KB, patch)
2016-05-18 16:29 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2016-05-18 18:48 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-05-18 16:29:21 PDT
Created attachment 279314 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-05-18 16:48:03 PDT
Comment on attachment 279314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279314&action=review > Source/WebCore/rendering/RenderView.cpp:280 > + state.m_isPaginated = !!state.m_pageLogicalHeight; I really think != 0 is better in these situations, and damn the style checker.
alan
Comment 3 2016-05-18 17:01:41 PDT
(In reply to comment #2) > Comment on attachment 279314 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279314&action=review > > > Source/WebCore/rendering/RenderView.cpp:280 > > + state.m_isPaginated = !!state.m_pageLogicalHeight; > > I really think != 0 is better in these situations, and damn the style > checker. Agree! It might even be more correct to check if state.m_pageLogicalHeight > 0
alan
Comment 4 2016-05-18 18:48:52 PDT
Created attachment 279335 [details] Patch
WebKit Commit Bot
Comment 5 2016-05-18 20:10:42 PDT
Comment on attachment 279335 [details] Patch Clearing flags on attachment: 279335 Committed r201124: <http://trac.webkit.org/changeset/201124>
WebKit Commit Bot
Comment 6 2016-05-18 20:10:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.