| Summary: | Add a test for site-specific quirk in CSS parser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ap, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2016-05-18 00:14:46 PDT
Created attachment 279224 [details]
Patch
Comment on attachment 279224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279224&action=review > LayoutTests/ChangeLog:10 > + * fast/css/site-specific-quirks-expected.html: Added. Is the intention to use this for multiple quirks? Otherwise, the test should have a more descriptive name (wikimedia-content-specific-css-quirk?) The bug should explain why we can't remove the quirk in foreseeable future (right now, it's not even related to the original bugs) > LayoutTests/platform/mac-wk1/TestExpectations:217 > js/dom/regress-157246.html > +fast/css/site-specific-quirks.html Could just as well use modern style with [ Skip ]. One way to avoid duplicating the expectations entry is to skip these tests in global TestExpectations, and enable them in LayoutTests/platform/wk2. Or an even better way - add LayoutTests/platform/wk1. Comment on attachment 279224 [details]
Patch
review- since we should address Alexey’s comments
|