Bug 157829

Summary: Web Inspector: ugly gaps in Call Trees data grid when expanding more than one level
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[SCREENSHOT] gaps
none
WIP
nvasilyev: review-, nvasilyev: commit-queue-
Patch none

Blaze Burg
Reported 2016-05-17 22:59:57 PDT
Created attachment 279215 [details] [SCREENSHOT] gaps Yuk.
Attachments
[SCREENSHOT] gaps (90.97 KB, image/png)
2016-05-17 22:59 PDT, Blaze Burg 		no flags
Details
WIP (1.21 KB, patch)
2016-05-18 12:58 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Patch (2.30 KB, patch)
2016-05-18 14:17 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-17 23:00:52 PDT
<rdar://problem/26339922>
Timothy Hatcher
Comment 2 2016-05-18 07:32:34 PDT
This might have regressed in: http://trac.webkit.org/changeset/200918/trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css Nikita, can you take a look?
Nikita Vasilyev
Comment 3 2016-05-18 08:02:25 PDT
Sure. I may have broken it.
Nikita Vasilyev
Comment 4 2016-05-18 12:58:51 PDT
Created attachment 279276 [details] WIP (In reply to comment #2) > This might have regressed in: > http://trac.webkit.org/changeset/200918/trunk/Source/WebInspectorUI/ > UserInterface/Views/DataGrid.css It regressed there, indeed. The selector I wrote isn't specific enough. This WIP fixes the issue, but it isn't a great solution. I'm thinking of something better.
Nikita Vasilyev
Comment 5 2016-05-18 14:17:47 PDT
Created attachment 279282 [details] Patch
WebKit Commit Bot
Comment 6 2016-05-18 15:15:23 PDT
Comment on attachment 279282 [details] Patch Clearing flags on attachment: 279282 Committed r201102: <http://trac.webkit.org/changeset/201102>
WebKit Commit Bot
Comment 7 2016-05-18 15:15:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.