Bug 157813

Summary: Web Inspector: NavigationSidebarPanel should coordinate item selection between its tree outlines
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 157713    
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix
none
[Patch] For Landing none

Matt Baker
Reported 2016-05-17 14:46:59 PDT
* SUMMARY NavigationSidebarPanel should coordinate item selection between its tree outlines. Debugger sidebar panel deselect tree elements as needed to prevent two selections in the sidebar, but this should be done by the base class. * NOTE DebuggerSidebarPanel._treeSelectionDidChange shadows the event listener in NavigationSidebarPanel, which means NavigationSidebarPanel._selectedContentTreeOutline will be in a base state. I'll address the issue as part of this change.
Attachments
[Patch] Proposed Fix (6.28 KB, patch)
2016-05-17 16:53 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (6.25 KB, patch)
2016-05-17 18:26 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] For Landing (6.25 KB, patch)
2016-05-17 18:55 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-17 14:47:37 PDT
<rdar://problem/26331779>
Radar WebKit Bug Importer
Comment 2 2016-05-17 14:48:21 PDT
<rdar://problem/26331796>
Matt Baker
Comment 3 2016-05-17 16:53:57 PDT
Created attachment 279184 [details] [Patch] Proposed Fix
Timothy Hatcher
Comment 4 2016-05-17 17:39:32 PDT
Comment on attachment 279184 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=279184&action=review > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:653 > + if (treeElement) { Return early instead? > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:664 > + this._selectedContentTreeOutline = selectedTreeOutline; Not used?
Matt Baker
Comment 5 2016-05-17 18:23:30 PDT
Comment on attachment 279184 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=279184&action=review >> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:664 >> + this._selectedContentTreeOutline = selectedTreeOutline; > > Not used? Used in NavigationSidebarPanel.show.
Matt Baker
Comment 6 2016-05-17 18:26:44 PDT
Created attachment 279193 [details] [Patch] Proposed Fix
Matt Baker
Comment 7 2016-05-17 18:55:31 PDT
Created attachment 279198 [details] [Patch] For Landing
WebKit Commit Bot
Comment 8 2016-05-17 19:25:15 PDT
Comment on attachment 279198 [details] [Patch] For Landing Clearing flags on attachment: 279198 Committed r201068: <http://trac.webkit.org/changeset/201068>
WebKit Commit Bot
Comment 9 2016-05-17 19:25:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.