Bug 157807

Summary:

Add test262 test files/yaml.

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

JavaScriptCore

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, keith_miller, ossy, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Keith Miller

Reported 2016-05-17 13:02:58 PDT

...

Attachments
Patch (deleted) 2016-05-17 13:09 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2016-05-17 13:09:42 PDT

Created attachment 279157 [details] Patch

Keith Miller

Comment 2 2016-05-17 13:26:11 PDT

I'm just going to land this. This patch adds a bunch of files that won't be run yet anyway.

Csaba Osztrogonác

Comment 3 2016-05-18 01:13:14 PDT

Please don't land it now, we could and should make the test262.yaml file less verbose and redundant. For example, harness/assert.js and harness.sta js are included by all "runTest262" test. I prefer adding these common harness files to includeFiles in runTest262 function instead. Additionally we could remove the ugly relative paths to harness files, all of them are in the same harness directory.

Csaba Osztrogonác

Comment 4 2016-05-18 02:25:51 PDT

typo: donePrintHandle.js -> doneprintHandle.js in the generated yaml file It would be great to mention which revision of test262 is checked in. At least in the bug report and commit log, but it would be better to have a revision.txt file or something similar.

Alex Christensen

Comment 5 2016-05-20 00:41:48 PDT

Should this still be r?

Csaba Osztrogonác

Comment 6 2016-07-15 01:52:27 PDT

landed in https://trac.webkit.org/changeset/203270 (In reply to comment #4) > It would be great to mention which revision of test262 is checked in. > At least in the bug report and commit log, but it would be better > to have a revision.txt file or something similar. I can't find the revision of test262 in that commit log. :( Please add a revision file, or mention it in the commit log which updates something in the test262 directory.

Csaba Osztrogonác

Comment 7 2016-07-19 11:35:12 PDT

(In reply to comment #6) > landed in https://trac.webkit.org/changeset/203270 > > (In reply to comment #4) > > It would be great to mention which revision of test262 is checked in. > > At least in the bug report and commit log, but it would be better > > to have a revision.txt file or something similar. > > I can't find the revision of test262 in that commit log. :( > Please add a revision file, or mention it in the commit log > which updates something in the test262 directory. Ping?

Keith Miller

Comment 8 2016-07-19 13:25:44 PDT

(In reply to comment #7) > (In reply to comment #6) > > landed in https://trac.webkit.org/changeset/203270 > > > > (In reply to comment #4) > > > It would be great to mention which revision of test262 is checked in. > > > At least in the bug report and commit log, but it would be better > > > to have a revision.txt file or something similar. > > > > I can't find the revision of test262 in that commit log. :( > > Please add a revision file, or mention it in the commit log > > which updates something in the test262 directory. > > Ping? Good idea. I opened a bugzilla: https://bugs.webkit.org/show_bug.cgi?id=159937

Yusuke Suzuki

Comment 9 2016-08-30 11:27:27 PDT

*** Bug 144241 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.