Bug 157753
| Summary: | Consider renaming activeDOMObjectsAreSuspended() to areActiveDOMObjectsSuspendingOrSuspended() for clarity | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, cdumez |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ada Chan
ScriptExecutionContext::stopActiveDOMObjects() has always set m_activeDOMObjectsAreStopped to true before stopping the objects. For ScriptExecutionContext::suspendActiveDOMObjects(), we've recently changed it to set m_activeDOMObjectsAreSuspended to true earlier to be consistent with the stop case in http://trac.webkit.org/changeset/200965.
Since the underlying booleans are updated right before we actually suspend/stop the objects, we should rename them to
m_activeDOMObjectsAreSuspendingOrSuspended
m_activeDOMObjectsAreStoppingOrStopped
for clarity.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |