Bug 157735

Summary: Modernize Track classes' code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-05-15 20:37:54 PDT
Modernize Track classes' code a bit.
Attachments
Patch (60.24 KB, patch)
2016-05-15 20:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (61.74 KB, patch)
2016-05-15 21:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (61.82 KB, patch)
2016-05-16 09:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-15 20:45:26 PDT
Created attachment 278995 [details] Patch
Chris Dumez
Comment 2 2016-05-15 21:05:24 PDT
Created attachment 278996 [details] Patch
Eric Carlson
Comment 3 2016-05-16 09:04:09 PDT
Comment on attachment 278996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278996&action=review > Source/WebCore/html/HTMLMediaElement.cpp:4015 > + TextTrack* track = trackList.item(i); Why not use auto& here? > Source/WebCore/html/track/VideoTrackList.cpp:90 > + auto& track = downcast<VideoTrack>(*m_inbandTracks[i]); > + if (track.selected()) Nit: is the local necessary?
Chris Dumez
Comment 4 2016-05-16 09:05:08 PDT
Comment on attachment 278996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278996&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:4015 >> + TextTrack* track = trackList.item(i); > > Why not use auto& here? Will do. >> Source/WebCore/html/track/VideoTrackList.cpp:90 >> + if (track.selected()) > > Nit: is the local necessary? I guess not :) Will update.
Chris Dumez
Comment 5 2016-05-16 09:07:13 PDT
Created attachment 279020 [details] Patch
WebKit Commit Bot
Comment 6 2016-05-16 09:36:30 PDT
Comment on attachment 279020 [details] Patch Clearing flags on attachment: 279020 Committed r200943: <http://trac.webkit.org/changeset/200943>
WebKit Commit Bot
Comment 7 2016-05-16 09:36:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.