Bug 157708
| Summary: | Extend protector naming code style guideline to cover RetainPtr with CF/ObjC types | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | darin, lforschler |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=157591 | ||
Brady Eidson
Extend protector naming code style guideline to cover RetainPtr with CF/ObjC types
This is a logical extension of https://bugs.webkit.org/show_bug.cgi?id=157591
Allowed names should be like:
RetainPtr<id> protectedSelf(self);
RetainPtr<id> protector(view);
RetainPtr<id> protectedView(view);
RetainPtr<CFStringRef> protector(cfString);
RetainPtr<CFStringRef> protectedCFString(cfString);
A search through the current tree might also reveal common patterns with adoptNS and adoptCF that should also be accounted for.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |