Bug 157697

Summary: Fix JSBench cause math domain error in run-benchmark script.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, glenn, rniwa, slewis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-yosemite
none
Patch for landing none

dewei_zhu
Reported 2016-05-13 17:34:43 PDT
Fix JSBench cause math domain error in run-benchmark script.
Attachments
Patch (2.59 KB, patch)
2016-05-13 17:38 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-yosemite (852.29 KB, application/zip)
2016-05-13 18:19 PDT, Build Bot 		no flags
Details
Patch for landing (2.59 KB, patch)
2016-05-13 21:08 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2016-05-13 17:38:47 PDT
Created attachment 278900 [details] Patch
Build Bot
Comment 2 2016-05-13 18:19:01 PDT
Comment on attachment 278900 [details] Patch Attachment 278900 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1317498 New failing tests: transitions/default-timing-function.html
Build Bot
Comment 3 2016-05-13 18:19:04 PDT
Created attachment 278904 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Ryosuke Niwa
Comment 4 2016-05-13 19:49:58 PDT
Comment on attachment 278900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278900&action=review > Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:92 > + # Be careful about round-off error when sample_stdev is 0. Nit: Wrong indentation.
dewei_zhu
Comment 5 2016-05-13 21:08:25 PDT
Created attachment 278919 [details] Patch for landing
Ryosuke Niwa
Comment 6 2016-05-13 21:16:37 PDT
Stephanie, could you merge this change back into your TA setup?
WebKit Commit Bot
Comment 7 2016-05-13 21:57:48 PDT
Comment on attachment 278919 [details] Patch for landing Clearing flags on attachment: 278919 Committed r200914: <http://trac.webkit.org/changeset/200914>
WebKit Commit Bot
Comment 8 2016-05-13 21:57:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.