Bug 157696

Summary: DFG/FTL have a few bugs in their reasoning about the scope
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, giffypap79, gskachkov, joepeck, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Saam Barati
Reported 2016-05-13 17:12:15 PDT
1. We should ensure that the scope is always flushed to the stack. This means claiming every node reads the scope when the debugger is enabled. 2. The FTL just has a bug where it doesn't properly set the scope register.
Attachments
patch (3.23 KB, patch)
2016-05-13 17:15 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (3.23 KB, patch)
2016-05-13 17:16 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-05-13 17:15:54 PDT
Created attachment 278897 [details] patch
Saam Barati
Comment 2 2016-05-13 17:16:50 PDT
Created attachment 278898 [details] patch
WebKit Commit Bot
Comment 3 2016-05-13 19:02:19 PDT
Comment on attachment 278898 [details] patch Clearing flags on attachment: 278898 Committed r200906: <http://trac.webkit.org/changeset/200906>
WebKit Commit Bot
Comment 4 2016-05-13 19:02:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.