Bug 157690

Summary: Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the stack
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mmaxfield: review+

Chris Dumez
Reported 2016-05-13 15:41:51 PDT
Make GlyphToPathTranslator fast allocated.
Attachments
Patch (1.24 KB, patch)
2016-05-13 15:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.17 KB, patch)
2016-05-13 16:04 PDT, Chris Dumez 		mmaxfield: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-13 15:44:18 PDT
Created attachment 278883 [details] Patch
Chris Dumez
Comment 2 2016-05-13 15:46:38 PDT
Other plan, I think we can just stack allocate it.
Myles C. Maxfield
Comment 3 2016-05-13 15:55:39 PDT
The Cocoa ports only use the MacGlyphToPathTranslator, and it's only used in one function, and it isn't a very big object, so putting it on the stack is a better idea. I don't know why I put it on the stack originally (maybe I was just being dumb). The other ports may have other subclasses of the GlyphToPathTranslator - it would be good if we could apply the same treatment to them too.
Chris Dumez
Comment 4 2016-05-13 16:04:37 PDT
Created attachment 278884 [details] Patch
Myles C. Maxfield
Comment 5 2016-05-14 02:39:28 PDT
Comment on attachment 278884 [details] Patch r=me assuming you fix the red EWS bubbles
Chris Dumez
Comment 6 2016-05-14 09:53:15 PDT
Committed r200919: <http://trac.webkit.org/changeset/200919>
Note You need to log in before you can comment on or make changes to this bug.