Summary: | Web Inspector: Computed style shows both prefixed and unprefixed variants of properties | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | Web Inspector | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Antoine Quint
2016-05-13 06:16:41 PDT
Created attachment 278837 [details]
Patch
Comment on attachment 278837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:962 > + return this._orderedStyles.some(function(style) { > + return style.properties.some(function (property) { We have been using arrow functions for things like this. They are fast! Also no space before (. Comment on attachment 278837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review > Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:211 > + Lately we've been making simple getters/settings one line: set implicit(implicit) { this._implicit = implicit; } Created attachment 279029 [details]
Patch for landing
Committed r200952: <http://trac.webkit.org/changeset/200952> Comment on attachment 279029 [details]
Patch for landing
Already landed it through my local checkout.
|