Bug 157673

Summary: Turn on WEB_TIMING for all ports
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, yoav
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yoav Weiss
Reported 2016-05-13 04:35:14 PDT
Turn on WEB_TIMING for all ports
Attachments
Patch (4.37 KB, patch)
2016-05-13 04:37 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2016-05-13 04:43 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2016-05-13 04:37:46 PDT
Created attachment 278834 [details] Patch
Yoav Weiss
Comment 2 2016-05-13 04:39:18 PDT
This turns on WEB_TIMING by default on the cmake Mac port, and makes sure that all ports have it on by default.
Yoav Weiss
Comment 3 2016-05-13 04:43:21 PDT
Created attachment 278835 [details] Patch
WebKit Commit Bot
Comment 4 2016-05-13 11:05:51 PDT
Comment on attachment 278835 [details] Patch Clearing flags on attachment: 278835 Committed r200863: <http://trac.webkit.org/changeset/200863>
WebKit Commit Bot
Comment 5 2016-05-13 11:05:54 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2016-05-13 20:14:01 PDT
Comment on attachment 278835 [details] Patch Awesome! How about we just remove the ENABLE flag entirely now that all ports enable it?
Yoav Weiss
Comment 7 2016-05-17 00:03:55 PDT
(In reply to comment #6) > Comment on attachment 278835 [details] > Patch > > Awesome! How about we just remove the ENABLE flag entirely now that all > ports enable it? I understood some people prefer to keep such flags in place in order to reduce binary size when building WebKit for e.g. embedded devices. OTOH, I'm not sure the impact of WEB_TIMING on binary size is significant. Should I ask webkit-dev before sending out a patch to remove the WEB_TIMING flag?
Note You need to log in before you can comment on or make changes to this bug.