Bug 157662

Summary: Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cdumez, commit-queue, darin, esprehn+autocc, ggaren, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154257    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-05-12 20:57:21 PDT
Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as it is no longer needed after <http://trac.webkit.org/changeset/196678>. JSC::getStaticPropertySlot() now properly checks for overrides *before* checking the static table.
Attachments
Patch (2.53 KB, patch)
2016-05-12 21:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-12 21:00:02 PDT
Created attachment 278809 [details] Patch
Chris Dumez
Comment 2 2016-05-12 21:00:41 PDT
The generated bindings look like so: bool JSWorkerGlobalScope::getOwnPropertySlot(JSObject* object, ExecState* state, PropertyName propertyName, PropertySlot& slot) { auto* thisObject = jsCast<JSWorkerGlobalScope*>(object); ASSERT_GC_OBJECT_INHERITS(thisObject, info()); if (getStaticPropertySlot<JSWorkerGlobalScope, Base>(state, JSWorkerGlobalScopeTable, thisObject, propertyName, slot)) return true; return false; }
WebKit Commit Bot
Comment 3 2016-05-12 23:27:44 PDT
Comment on attachment 278809 [details] Patch Clearing flags on attachment: 278809 Committed r200814: <http://trac.webkit.org/changeset/200814>
WebKit Commit Bot
Comment 4 2016-05-12 23:27:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.