Bug 157632

Summary: Unprefix -webkit-cross-fade()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ImagesAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: 50167214, dino, eoconnor, fs, graouts, simon.fraser
Priority: P2 Keywords: WebExposed
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2016-05-12 11:48:35 PDT
We should unprefix this: https://drafts.csswg.org/css-images/#cross-fade-function
Attachments
Patch (39.23 KB, patch)
2016-05-12 21:34 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-05-12 21:34:20 PDT
Created attachment 278813 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-05-13 15:40:34 PDT
https://trac.webkit.org/r200888
yisibl
Comment 3 2016-05-25 22:43:14 PDT
Webkit implementation of the grammar and the latest spec are not the same. cross-fade() = cross-fade( <cf-mixing-image> , <cf-final-image>? ) <cf-mixing-image> = <percentage>? && <image> <cf-final-image> = <image> | <color> So we have to put the percentage in front of it, and remove the comma. Before: -webkit-cross-fade(url(foo.png), url(bar.png), 20%) After: cross-fade(20% url(foo.png), url(bar.png))
yisibl
Comment 4 2016-05-25 22:45:10 PDT
And support <color> cross-fade(20% url(foo.png), #000)
Fredrik Söderquist
Comment 5 2017-11-22 05:32:05 PST
I filed bug 179942 for following up on comment 3.
Note You need to log in before you can comment on or make changes to this bug.