Bug 157622

Summary: [css-grid] Show auto-repeat line names in ComputedStyle
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, jfernandez, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch darin: review+

Sergio Villar Senin
Reported 2016-05-12 03:49:21 PDT
[css-grid] Show auto-repeat line names in ComputedStyle
Attachments
Patch (14.68 KB, patch)
2016-05-12 04:04 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2016-05-12 04:04:28 PDT
Created attachment 278727 [details] Patch
Manuel Rego Casasnovas
Comment 2 2016-05-12 05:59:15 PDT
Comment on attachment 278727 [details] Patch LGTM.
Darin Adler
Comment 3 2016-05-12 08:51:56 PDT
Comment on attachment 278727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278727&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1109 > RefPtr<CSSGridLineNamesValue> lineNames = CSSGridLineNamesValue::create(); This local variable should be auto, not RefPtr, and I think it would then be a Ref. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1112 > + list.append(lineNames.releaseNonNull()); Then this would be WTFMove, not releaseNonNull.
Sergio Villar Senin
Comment 4 2016-05-13 00:41:07 PDT
Committed r200821: <http://trac.webkit.org/changeset/200821>
Note You need to log in before you can comment on or make changes to this bug.