Bug 157622 - [css-grid] Show auto-repeat line names in ComputedStyle
Summary: [css-grid] Show auto-repeat line names in ComputedStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2016-05-12 03:49 PDT by Sergio Villar Senin
Modified: 2016-05-13 00:41 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.68 KB, patch)
2016-05-12 04:04 PDT, Sergio Villar Senin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2016-05-12 03:49:21 PDT
[css-grid] Show auto-repeat line names in ComputedStyle
Comment 1 Sergio Villar Senin 2016-05-12 04:04:28 PDT
Created attachment 278727 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2016-05-12 05:59:15 PDT
Comment on attachment 278727 [details]
Patch

LGTM.
Comment 3 Darin Adler 2016-05-12 08:51:56 PDT
Comment on attachment 278727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278727&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1109
>      RefPtr<CSSGridLineNamesValue> lineNames = CSSGridLineNamesValue::create();

This local variable should be auto, not RefPtr, and I think it would then be a Ref.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1112
> +        list.append(lineNames.releaseNonNull());

Then this would be WTFMove, not releaseNonNull.
Comment 4 Sergio Villar Senin 2016-05-13 00:41:07 PDT
Committed r200821: <http://trac.webkit.org/changeset/200821>