Bug 157602

Summary: Web Inspector: `this` in Scope Chain Sidebar does not have preview, looks poor
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2016-05-11 17:48:23 PDT
* SUMMARY `this` in Scope Chain Sidebar does not have preview, looks poor * TEST <body><img id="x"> <script> function foo() { let x = 1; console.log(this); debugger; } foo.call(window.x); </script> * STEPS TO REPRODUCE 1. Inspect test page 2. Reload => Pause 3. Show Scope Chain Sidebar in Debugger Tab => The `this` in the Local Variables scope is not pretty, because it lacks a preview
Attachments
[PATCH] Proposed Fix (1.55 KB, patch)
2016-05-11 17:49 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (104.93 KB, image/png)
2016-05-11 17:52 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (110.28 KB, image/png)
2016-05-11 17:52 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-05-11 17:49:26 PDT
Created attachment 278686 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2016-05-11 17:52:09 PDT
Created attachment 278687 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2016-05-11 17:52:21 PDT
Created attachment 278688 [details] [IMAGE] After
WebKit Commit Bot
Comment 4 2016-05-11 19:13:01 PDT
Comment on attachment 278686 [details] [PATCH] Proposed Fix Clearing flags on attachment: 278686 Committed r200737: <http://trac.webkit.org/changeset/200737>
WebKit Commit Bot
Comment 5 2016-05-11 19:13:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.