Bug 157562

Summary: [curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, beidson, bfulgham, commit-queue, darin, fpizlo, ggaren, peavo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2016-05-11 02:52:03 PDT
[curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter

In Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp (SocketStreamHandle::startThread),
there is a following code:

> curl_easy_setopt(curlHandle, CURLOPT_CONNECT_ONLY)

Required third argument is missing. This should be

> curl_easy_setopt(curlHandle, CURLOPT_CONNECT_ONLY, 1L)

Documentation: https://curl.haxx.se/libcurl/c/CURLOPT_CONNECT_ONLY.html
Introduced in Bug 144628.
Comment 1 Fujii Hironori 2016-05-11 03:03:19 PDT
Created attachment 278610 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-11 09:17:51 PDT
Comment on attachment 278610 [details]
Patch

Clearing flags on attachment: 278610

Committed r200687: <http://trac.webkit.org/changeset/200687>
Comment 3 WebKit Commit Bot 2016-05-11 09:17:56 PDT
All reviewed patches have been landed.  Closing bug.