Bug 157522

Summary: [SpeculativeValidation] Do not start a preload if there is already one pending
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, cgarcia, commit-queue, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-05-10 09:32:59 PDT 
Do not start a preload if there is already one pending. We failed to check in SpeculativeLoadManager::preloadEntry() if there was already a pending preload. As a result, we would sometimes cancel an already pending preload and start one from scratch which is inefficient. It would also sometimes lead to hitting an assertion in the SpeculativeLoad destructor because we could destroy the SpeculativeLoad without finishing or cancelling the load.
Comment 1 Chris Dumez 2016-05-10 09:33:18 PDT 
<rdar://problem/26156083>
Comment 2 Chris Dumez 2016-05-10 09:41:07 PDT 
Created attachment 278504 [details]
Patch
Comment 3 Chris Dumez 2016-05-10 10:44:59 PDT 
Comment on attachment 278504 [details]
Patch

Clearing flags on attachment: 278504

Committed r200630: <http://trac.webkit.org/changeset/200630>
Comment 4 Chris Dumez 2016-05-10 10:45:03 PDT 
All reviewed patches have been landed.  Closing bug.