Bug 157522 - [SpeculativeValidation] Do not start a preload if there is already one pending
Summary: [SpeculativeValidation] Do not start a preload if there is already one pending
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2016-05-10 09:32 PDT by Chris Dumez
Modified: 2016-05-10 10:45 PDT (History)
6 users (show)

See Also:

Patch (2.52 KB, patch)
2016-05-10 09:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-05-10 09:32:59 PDT
Do not start a preload if there is already one pending. We failed to check in SpeculativeLoadManager::preloadEntry() if there was already a pending preload. As a result, we would sometimes cancel an already pending preload and start one from scratch which is inefficient. It would also sometimes lead to hitting an assertion in the SpeculativeLoad destructor because we could destroy the SpeculativeLoad without finishing or cancelling the load.
Comment 1 Chris Dumez 2016-05-10 09:33:18 PDT
Comment 2 Chris Dumez 2016-05-10 09:41:07 PDT
Created attachment 278504 [details]
Comment 3 Chris Dumez 2016-05-10 10:44:59 PDT
Comment on attachment 278504 [details]

Clearing flags on attachment: 278504

Committed r200630: <http://trac.webkit.org/changeset/200630>
Comment 4 Chris Dumez 2016-05-10 10:45:03 PDT
All reviewed patches have been landed.  Closing bug.