Bug 157513

Summary:	Fix the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build after r198927
Product:	WebKit	Reporter:	Csaba Osztrogonác <ossy>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	benjamin, caitp, ggaren, ossy, saam
Priority:	P2
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	155988

Description Csaba Osztrogonác 2016-05-10 06:35:21 PDT

http://trac.webkit.org/changeset/192661 broke the !ENABLE(ES6_ARROW_SYNTAX) build

build log:
../../Source/JavaScriptCore/parser/Parser.cpp: In member function 'typename TreeBuilder::Expression JSC::Parser<LexerType>::parseAssignmentExpression(TreeBuilder&, JSC::Parser<LexerType>::ExpressionErrorClassifier&)':
../../Source/JavaScriptCore/parser/Parser.cpp:3090:26: error: 'savePoint' was not declared in this scope

savePoint is defined inside ENABLE(ES6_ARROWFUNCTION_SYNTAX) guard, but used without guards.

r192661 is a half year old change and nobody noticed this breakage since then.
Should we fix this error or should we remove these broken guards?

Comment 1 Caitlin Potter (:caitp) 2016-05-10 06:46:34 PDT

It's broken in trunk, but that changeset does not have this issue.

The savePoint was put inside the ENABLE(ES6_ARROW_SYNTAX) guards in http://trac.webkit.org/changeset/198927 several weeks ago.

/CC sbarati@apple.com

Comment 2 Csaba Osztrogonác 2016-05-10 06:48:48 PDT

(In reply to comment #1)
> It's broken in trunk, but that changeset does not have this issue.
> 
> The savePoint was put inside the ENABLE(ES6_ARROW_SYNTAX) guards in
> http://trac.webkit.org/changeset/198927 several weeks ago.
> 
> /CC sbarati@apple.com

Really, you're right.

Comment 3 Saam Barati 2016-05-10 08:49:23 PDT

We should just get rid of ENABLE_ES6_ARROW_SYNTAX

It's stable now and shouldn't be behind a compile time flag.

Comment 4 Csaba Osztrogonác 2016-05-11 03:10:32 PDT

Filed a new bug report to remove this guard - bug157564 .