Bug 157501

Summary: [iOS] <select> elements should render right-aligned when in RTL mode
Product: WebKit Reporter: Dean Jackson <dino>
Component: FormsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
graouts: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Dean Jackson
Reported 2016-05-09 20:08:09 PDT
This is the equivalent of 157112 for iOS.
Attachments
Patch (36.45 KB, patch)
2016-05-09 20:22 PDT, Dean Jackson 		graouts: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.22 MB, application/zip)
2016-05-09 21:26 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-09 20:08:27 PDT
<rdar://problem/26187870>
Dean Jackson
Comment 2 2016-05-09 20:22:28 PDT
Created attachment 278471 [details] Patch
Build Bot
Comment 3 2016-05-09 21:26:57 PDT
Comment on attachment 278471 [details] Patch Attachment 278471 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1296556 New failing tests: fast/text/international/pop-up-button-text-alignment-and-direction.html fast/forms/select-writing-direction-natural.html fast/forms/listbox-bidi-align.html fast/text/international/bidi-listbox-atsui.html fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html fast/text/international/bidi-listbox.html fast/text/international/bidi-menulist.html
Build Bot
Comment 4 2016-05-09 21:26:59 PDT
Created attachment 278476 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Antoine Quint
Comment 5 2016-05-10 04:34:16 PDT
Comment on attachment 278471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278471&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:685 > + buttonClip = FloatRect(separatorPosition - adjustTop, clip.y() - adjustTop, MenuListButtonPaddingAfter + adjustTop + adjustRight, clip.height() + adjustTop + adjustBottom); Maybe use a ternary operator here?
Dean Jackson
Comment 6 2016-05-10 04:37:35 PDT
Comment on attachment 278471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278471&action=review >> Source/WebCore/rendering/RenderThemeIOS.mm:685 >> + buttonClip = FloatRect(separatorPosition - adjustTop, clip.y() - adjustTop, MenuListButtonPaddingAfter + adjustTop + adjustRight, clip.height() + adjustTop + adjustBottom); > > Maybe use a ternary operator here? I didn't use one because the line is already crazyily long.
Dean Jackson
Comment 7 2016-05-10 04:41:02 PDT
Committed r200620: <http://trac.webkit.org/changeset/200620>
Note You need to log in before you can comment on or make changes to this bug.