Bug 157489

Summary: Clean up iOS text autosizing code
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+, zalan: commit-queue-

Simon Fraser (smfr)
Reported 2016-05-09 14:12:21 PDT
Clean up iOS text autosizing code
Attachments
Patch (12.11 KB, patch)
2016-05-09 14:13 PDT, Simon Fraser (smfr) 		zalan: review+
zalan: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-05-09 14:13:07 PDT
Created attachment 278438 [details] Patch
alan
Comment 2 2016-05-09 14:32:21 PDT
Comment on attachment 278438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278438&action=review > Source/WebCore/rendering/RenderElement.cpp:2174 > + const RenderStyle& style = renderer.style(); use auto please. > Source/WebCore/rendering/TextAutoSizing.cpp:102 > + RenderText& renderText = downcast<RenderText>(*autoSizingNode->renderer()); auto. > Source/WebCore/rendering/TextAutoSizing.cpp:111 > + RenderText* text = downcast<RenderText>(autoSizingNode->renderer()); auto. > Source/WebCore/rendering/TextAutoSizing.cpp:171 > + RenderText* text = downcast<RenderText>(autoSizingNode->renderer()); auto.
Simon Fraser (smfr)
Comment 3 2016-05-09 14:57:45 PDT
https://trac.webkit.org/r200593
Note You need to log in before you can comment on or make changes to this bug.