Bug 157489 - Clean up iOS text autosizing code
Summary: Clean up iOS text autosizing code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-09 14:12 PDT by Simon Fraser (smfr)
Modified: 2016-05-09 14:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.11 KB, patch)
2016-05-09 14:13 PDT, Simon Fraser (smfr) 		zalan: review+
zalan: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-05-09 14:12:21 PDT 
Clean up iOS text autosizing code
Comment 1 Simon Fraser (smfr) 2016-05-09 14:13:07 PDT 
Created attachment 278438 [details]
Patch
Comment 2 zalan 2016-05-09 14:32:21 PDT 
Comment on attachment 278438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278438&action=review

> Source/WebCore/rendering/RenderElement.cpp:2174
> +    const RenderStyle& style = renderer.style();

use auto please.

> Source/WebCore/rendering/TextAutoSizing.cpp:102
> +        RenderText& renderText = downcast<RenderText>(*autoSizingNode->renderer());

auto.

> Source/WebCore/rendering/TextAutoSizing.cpp:111
> +        RenderText* text = downcast<RenderText>(autoSizingNode->renderer());

auto.

> Source/WebCore/rendering/TextAutoSizing.cpp:171
> +        RenderText* text = downcast<RenderText>(autoSizingNode->renderer());

auto.
Comment 3 Simon Fraser (smfr) 2016-05-09 14:57:45 PDT 
https://trac.webkit.org/r200593