Bug 157488

Summary: Web Inspector: Cleanup super getter/setter now that underlying issue is fixed
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Joseph Pecoraro
Reported 2016-05-09 13:44:05 PDT
Cleanup super getter/setter now that underlying issue is fixed: Bug 147064 is fixed, so that means we should be able to address these FIXMEs: Views/VisualStyleKeywordPicker.js 56: // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object 62: // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object 76: // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object Views/VisualStyleNumberInputBox.js 218: // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object
Attachments
Patch (8.08 KB, patch)
2016-05-10 00:41 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (708.76 KB, application/zip)
2016-05-10 02:33 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-09 13:44:43 PDT
<rdar://problem/26179120>
Devin Rousso
Comment 2 2016-05-10 00:41:42 PDT
Created attachment 278483 [details] Patch
Build Bot
Comment 3 2016-05-10 02:33:00 PDT
Comment on attachment 278483 [details] Patch Attachment 278483 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1297702 New failing tests: fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html
Build Bot
Comment 4 2016-05-10 02:33:02 PDT
Created attachment 278485 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Blaze Burg
Comment 5 2016-05-10 09:44:49 PDT
Comment on attachment 278483 [details] Patch r=me
WebKit Commit Bot
Comment 6 2016-05-10 10:42:10 PDT
Comment on attachment 278483 [details] Patch Clearing flags on attachment: 278483 Committed r200629: <http://trac.webkit.org/changeset/200629>
WebKit Commit Bot
Comment 7 2016-05-10 10:42:15 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 8 2016-05-10 11:49:09 PDT
Comment on attachment 278483 [details] Patch Nice! Thanks for updating this, I had written a patch locally and it wasn't as complete as this =)
Note You need to log in before you can comment on or make changes to this bug.