Bug 157478

Summary: Web Inspector: Remove Global Breakpoints folder
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] UI without folder
none
[Patch] Proposed Fix none

Timothy Hatcher
Reported 2016-05-09 12:01:51 PDT
We should have a flat list of the global breakpoints.
Attachments
[Image] UI without folder (134.18 KB, image/png)
2016-05-09 15:45 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (6.45 KB, patch)
2016-05-09 15:49 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-09 12:02:39 PDT
<rdar://problem/26176524>
Matt Baker
Comment 2 2016-05-09 12:42:04 PDT
While we're simplifying Global Breakpoints, does it make sense for these to be selectable? Maybe clicking anywhere in the tree item should just toggle the breakpoint status.
Timothy Hatcher
Comment 3 2016-05-09 14:54:04 PDT
(In reply to comment #2) > While we're simplifying Global Breakpoints, does it make sense for these to > be selectable? Maybe clicking anywhere in the tree item should just toggle > the breakpoint status. Space bar will toggle them, so I think we should keep them keyboard reachable.
Matt Baker
Comment 4 2016-05-09 15:45:15 PDT
Created attachment 278449 [details] [Image] UI without folder My feeling is that a divider line isn't necessary between "special" and "user" breakpoints
Matt Baker
Comment 5 2016-05-09 15:49:02 PDT
Created attachment 278451 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 6 2016-05-09 17:01:43 PDT
Comment on attachment 278451 [details] [Patch] Proposed Fix Clearing flags on attachment: 278451 Committed r200600: <http://trac.webkit.org/changeset/200600>
WebKit Commit Bot
Comment 7 2016-05-09 17:01:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.