Bug 15746

Summary: #ifndef ASSERT_DISABLED is no good!
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch darin: review+

Geoffrey Garen
Reported 2007-10-28 22:38:02 PDT
ASSERT_DISABLED is always defined in Mac OS X builds, so code that relies on #ifndef ASSERT_DISABLED to do debugging won't work. We have code like this in, for example, HashTable.h
Attachments
Patch (2.84 KB, patch)
2007-10-28 22:46 PDT, Geoffrey Garen 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2007-10-28 22:46:34 PDT
Created attachment 16933 [details] Patch Mac debug and release builds succeed.
Geoffrey Garen
Comment 2 2007-10-28 23:04:55 PDT
Committed revision 27211.
Note You need to log in before you can comment on or make changes to this bug.