Bug 157441

Summary: [iOS WK2] Font size increases on some pages after navigating then going back
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Severity: Normal CC: enrica, simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=157589
Description Flags
Patch darin: review+

Description Simon Fraser (smfr) 2016-05-06 18:31:37 PDT
[iOS WK2] Font size increases on some pages after navigating then going back
Comment 1 Simon Fraser (smfr) 2016-05-06 18:35:43 PDT
Created attachment 278302 [details]
Comment 2 Darin Adler 2016-05-07 12:36:29 PDT
Comment on attachment 278302 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=278302&action=review

> Source/WebCore/ChangeLog:9
> +        Sometimes I want to dump ViewportConfigurations from WebKit2 so export dump().

Seems like we’d want to export all or most of these “debug only for calling from the debugger” functions, not just this one.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2652
> -    setFixedLayoutSize(newLayoutSize);
> +    if (setFixedLayoutSize(newLayoutSize))
> +        resetTextAutosizing();

Should we build this behavior into the setFixedLayoutSize function instead of changing all call sites, or is there a valuable separation of responsibilities here?
Comment 3 Simon Fraser (smfr) 2016-05-09 14:16:30 PDT