Bug 15744

Summary:

Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode to the AST transform

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

JavaScriptCore

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

14868

Attachments:

Description	Flags
Patch	darin: review-
Patch2	darin: review+

Description Geoffrey Garen 2007-10-28 21:34:35 PDT

Subtask of bug 14868.

Comment 1 Geoffrey Garen 2007-10-28 21:34:57 PDT

Created attachment 16931 [details]
Patch

Comment 2 Darin Adler 2007-10-28 22:03:09 PDT

Comment on attachment 16931 [details]
Patch

+JSValue* LocalVarDeleteNode::evaluate(ExecState* exec)

Unused parameter. Will warn when you merge with my settings.

+        , ident(ident)
+        , args(args.release())

These should both pass PlacementNewAdopt. See my recent patch for details.

Otherwise great!

Comment 3 Geoffrey Garen 2007-10-28 22:24:49 PDT

Created attachment 16932 [details]
Patch2

Factored ASSERT code out into canSkipLookup. Removed unused parameter.

Comment 4 Geoffrey Garen 2007-10-28 22:25:06 PDT

Also used the right initializers.

Comment 5 Darin Adler 2007-10-28 22:31:31 PDT

Comment on attachment 16932 [details]
Patch2

I'm worried about warnings in release builds due to the unused function.

r=me

Comment 6 Geoffrey Garen 2007-10-28 22:43:43 PDT

Committed revision 27210, with an #if !ASSERT_DISABLED.