Bug 15744

Summary: Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode to the AST transform
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 14868    
Attachments:
Description Flags
Patch
darin: review-
Patch2 darin: review+

Geoffrey Garen
Reported 2007-10-28 21:34:35 PDT
Subtask of bug 14868.
Attachments
Patch (12.49 KB, patch)
2007-10-28 21:34 PDT, Geoffrey Garen 		darin: review-
DetailsFormatted DiffDiff
Patch2 (13.32 KB, patch)
2007-10-28 22:24 PDT, Geoffrey Garen 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2007-10-28 21:34:57 PDT
Created attachment 16931 [details] Patch
Darin Adler
Comment 2 2007-10-28 22:03:09 PDT
Comment on attachment 16931 [details] Patch +JSValue* LocalVarDeleteNode::evaluate(ExecState* exec) Unused parameter. Will warn when you merge with my settings. + , ident(ident) + , args(args.release()) These should both pass PlacementNewAdopt. See my recent patch for details. Otherwise great!
Geoffrey Garen
Comment 3 2007-10-28 22:24:49 PDT
Created attachment 16932 [details] Patch2 Factored ASSERT code out into canSkipLookup. Removed unused parameter.
Geoffrey Garen
Comment 4 2007-10-28 22:25:06 PDT
Also used the right initializers.
Darin Adler
Comment 5 2007-10-28 22:31:31 PDT
Comment on attachment 16932 [details] Patch2 I'm worried about warnings in release builds due to the unused function. r=me
Geoffrey Garen
Comment 6 2007-10-28 22:43:43 PDT
Committed revision 27210, with an #if !ASSERT_DISABLED.
Note You need to log in before you can comment on or make changes to this bug.