Summary: | Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||||
Component: | WebKit2 | Assignee: | Ada Chan <adachan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, buildbot, rniwa | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ada Chan
2016-05-06 16:10:49 PDT
Created attachment 278288 [details]
Patch
Comment on attachment 278288 [details] Patch Attachment 278288 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1279090 Number of test failures exceeded the failure limit. Created attachment 278293 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 278319 [details]
Patch
Comment on attachment 278319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278319&action=review > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:62 > +#if !TARGET_OS_IPHONE I think that #if TARGET_OS_MAC might be more forward looking that specifically assuming that all !IPHONE will have this enhanced fullscreen thing. > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm:132 > +#if !TARGET_OS_IPHONE Here in the .mm file we can and should use #if PLATFORM(MAC) instead. Comment on attachment 278319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278319&action=review Thanks for the review! >> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:62 >> +#if !TARGET_OS_IPHONE > > I think that #if TARGET_OS_MAC might be more forward looking that specifically assuming that all !IPHONE will have this enhanced fullscreen thing. Changed to use #if TARGET_OS_MAC. >> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm:132 >> +#if !TARGET_OS_IPHONE > > Here in the .mm file we can and should use #if PLATFORM(MAC) instead. Changed to use #if PLATFORM(MAC) Committed: http://trac.webkit.org/changeset/200592 |