Bug 157434

Summary: Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Patch darin: review+

Ada Chan
Reported 2016-05-06 16:10:49 PDT
Adding this to WKPagePrivateMac.h: WK_EXPORT bool WKPageIsPlayingVideoInEnhancedFullscreen(WKPageRef page); Needed for <rdar://problem/24592796>
Attachments
Patch (5.21 KB, patch)
2016-05-06 16:31 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (919.69 KB, application/zip)
2016-05-06 17:06 PDT, Build Bot 		no flags
Details
Patch (5.27 KB, patch)
2016-05-06 22:23 PDT, Ada Chan 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2016-05-06 16:31:52 PDT
Created attachment 278288 [details] Patch
Build Bot
Comment 2 2016-05-06 17:06:44 PDT
Comment on attachment 278288 [details] Patch Attachment 278288 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1279090 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2016-05-06 17:06:47 PDT
Created attachment 278293 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Ada Chan
Comment 4 2016-05-06 22:23:03 PDT
Created attachment 278319 [details] Patch
Darin Adler
Comment 5 2016-05-07 12:28:25 PDT
Comment on attachment 278319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278319&action=review > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:62 > +#if !TARGET_OS_IPHONE I think that #if TARGET_OS_MAC might be more forward looking that specifically assuming that all !IPHONE will have this enhanced fullscreen thing. > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm:132 > +#if !TARGET_OS_IPHONE Here in the .mm file we can and should use #if PLATFORM(MAC) instead.
Ada Chan
Comment 6 2016-05-09 14:33:12 PDT
Comment on attachment 278319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278319&action=review Thanks for the review! >> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:62 >> +#if !TARGET_OS_IPHONE > > I think that #if TARGET_OS_MAC might be more forward looking that specifically assuming that all !IPHONE will have this enhanced fullscreen thing. Changed to use #if TARGET_OS_MAC. >> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm:132 >> +#if !TARGET_OS_IPHONE > > Here in the .mm file we can and should use #if PLATFORM(MAC) instead. Changed to use #if PLATFORM(MAC)
Ada Chan
Comment 7 2016-06-05 12:43:48 PDT
Committed: http://trac.webkit.org/changeset/200592
Note You need to log in before you can comment on or make changes to this bug.