Bug 157428

Summary: Add JSC options bytecodeRangeToJITCompile and jitWhitelist.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
msaboff: review-
proposed patch with Michael's feedback. msaboff: review+

Mark Lam
Reported 2016-05-06 13:17:04 PDT
... because this is useful for baseline JIT debugging too.
Attachments
proposed patch (32.50 KB, patch)
2016-05-06 17:03 PDT, Mark Lam 		msaboff: review-
DetailsFormatted DiffDiff
proposed patch with Michael's feedback. (32.41 KB, patch)
2016-05-06 18:54 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-05-06 17:03:31 PDT
Created attachment 278290 [details] proposed patch
Michael Saboff
Comment 2 2016-05-06 17:11:09 PDT
Comment on attachment 278290 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=278290&action=review r- Please make the suggested changes. > Source/JavaScriptCore/ChangeLog:35 > + * jit/JITFunctionWhitelist.cpp: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp. > + (JSC::JITFunctionWhitelist::ensureGlobalBaselineWhitelist): > + (JSC::JITFunctionWhitelist::ensureGlobalDFGWhitelist): > + (JSC::JITFunctionWhitelist::JITFunctionWhitelist): > + (JSC::JITFunctionWhitelist::parseFunctionNamesInFile): > + (JSC::JITFunctionWhitelist::contains): > + (JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist): Deleted. > + (JSC::DFG::FunctionWhitelist::FunctionWhitelist): Deleted. > + (JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile): Deleted. > + (JSC::DFG::FunctionWhitelist::contains): Deleted. > + * jit/JITFunctionWhitelist.h: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.h. Make this a generic FunctionWhiteList class. > Source/JavaScriptCore/runtime/Options.h:148 > + v(optionRange, bytecodeRangeToBaselineCompile, 0, Normal, "bytecode size range to allow Baseline JIT compilation on, e.g. 1:100") \ Let's call this "bytecodeRangeToJITCompile". > Source/JavaScriptCore/runtime/Options.h:151 > + v(optionString, baselineWhitelist, nullptr, Normal, "file with list of function signatures to allow Baseline JIT compilation on") \ Let's call this "jitWhitelist"
Mark Lam
Comment 3 2016-05-06 18:54:45 PDT
Created attachment 278308 [details] proposed patch with Michael's feedback.
Michael Saboff
Comment 4 2016-05-07 07:40:41 PDT
Comment on attachment 278308 [details] proposed patch with Michael's feedback. r=me
Mark Lam
Comment 5 2016-05-07 09:20:07 PDT
Thanks for the review. Landed in r200543: <http://trac.webkit.org/r200543>.
Note You need to log in before you can comment on or make changes to this bug.