Bug 157425

Summary: <attachment> element should understand UTIs
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch andersca: review+

Tim Horton
Reported 2016-05-06 13:06:01 PDT
<attachment> element should understand UTIs
Attachments
Patch (10.31 KB, patch)
2016-05-06 13:06 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (637.75 KB, application/zip)
2016-05-06 14:12 PDT, Build Bot 		no flags
Details
Patch (10.29 KB, patch)
2016-05-06 14:15 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-05-06 13:06:28 PDT
Created attachment 278261 [details] Patch
Tim Horton
Comment 2 2016-05-06 13:08:57 PDT
<rdar://problem/25585401>
Build Bot
Comment 3 2016-05-06 14:12:22 PDT
Comment on attachment 278261 [details] Patch Attachment 278261 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1278385 New failing tests: fast/attachment/attachment-uti.html
Build Bot
Comment 4 2016-05-06 14:12:25 PDT
Created attachment 278266 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Tim Horton
Comment 5 2016-05-06 14:15:59 PDT
Created attachment 278268 [details] Patch
Anders Carlsson
Comment 6 2016-05-06 14:20:18 PDT
Comment on attachment 278268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278268&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1500 > + RetainPtr<UIDocumentInteractionController> documentInteractionController = adoptNS([[getUIDocumentInteractionControllerClass() alloc] init]); Use auto here. > Source/WebCore/rendering/RenderThemeIOS.mm:1512 > + RetainPtr<CFStringRef> attachmentTypeCF = attachmentType.createCFString(); Again, auto here. > Source/WebCore/rendering/RenderThemeMac.mm:2414 > + RetainPtr<CFStringRef> attachmentTypeCF = attachmentType.createCFString(); Use auto here.
Tim Horton
Comment 7 2016-05-06 15:52:12 PDT
http://trac.webkit.org/changeset/200530
Note You need to log in before you can comment on or make changes to this bug.