Summary: | Refactor FocusController::findFocusableElementRecursively | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | UI Events | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, kling, koivisto, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 151379 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2016-05-05 23:01:12 PDT
Created attachment 278240 [details]
Cleanup
Created attachment 278243 [details]
Renamed one more function
Comment on attachment 278243 [details] Renamed one more function View in context: https://bugs.webkit.org/attachment.cgi?id=278243&action=review I am getting lost in all these super-long function names. The new names do seem more accurate and precise. > Source/WebCore/page/FocusController.cpp:435 > + while (owner) { This would be more readable as a for loop, but I guess it’s hard to get outerScope into something visible in the loop condition. Thanks for the review! (In reply to comment #3) > Comment on attachment 278243 [details] > Renamed one more function > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278243&action=review > > I am getting lost in all these super-long function names. The new names do > seem more accurate and precise. Hopefully next round of cleanup will help. > > Source/WebCore/page/FocusController.cpp:435 > > + while (owner) { > > This would be more readable as a for loop, but I guess it’s hard to get > outerScope into something visible in the loop condition. Yeah, I thought about the same thing but I didn't want to move FocusNavigationScope out of the loop. Comment on attachment 278243 [details] Renamed one more function Clearing flags on attachment: 278243 Committed r200576: <http://trac.webkit.org/changeset/200576> All reviewed patches have been landed. Closing bug. |