Bug 157390

Summary: Add WebKitAdditions extension points in media controls related code in RenderThemeMac
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Ada Chan
Reported 2016-05-05 14:34:52 PDT
Add WebKitAdditions extension points in media controls related code in RenderThemeMac. For <rdar://problem/25837401>
Attachments
Patch (2.87 KB, patch)
2016-05-05 15:11 PDT, Ada Chan 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2016-05-05 15:11:04 PDT
Created attachment 278195 [details] Patch
Anders Carlsson
Comment 2 2016-05-05 16:09:16 PDT
Comment on attachment 278195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278195&action=review > Source/WebCore/rendering/RenderThemeMac.mm:238 > +#if USE(APPLE_INTERNAL_SDK) > +#import <WebKitAdditions/RenderThemeMacMediaControlsStyleSheetAdditions.mm> > +#endif I'd put newlines before and after this to make it look less crowded. > Source/WebCore/rendering/RenderThemeMac.mm:256 > +#if USE(APPLE_INTERNAL_SDK) > +#import <WebKitAdditions/RenderThemeMacMediaControlsScriptAdditions.mm> > +#endif Same here!
Ada Chan
Comment 3 2016-05-05 16:31:40 PDT
(In reply to comment #2) > Comment on attachment 278195 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278195&action=review > > > Source/WebCore/rendering/RenderThemeMac.mm:238 > > +#if USE(APPLE_INTERNAL_SDK) > > +#import <WebKitAdditions/RenderThemeMacMediaControlsStyleSheetAdditions.mm> > > +#endif > > I'd put newlines before and after this to make it look less crowded. > > > Source/WebCore/rendering/RenderThemeMac.mm:256 > > +#if USE(APPLE_INTERNAL_SDK) > > +#import <WebKitAdditions/RenderThemeMacMediaControlsScriptAdditions.mm> > > +#endif > > Same here! Newlines added. Thanks for the review! Committed: http://trac.webkit.org/changeset/200491
Note You need to log in before you can comment on or make changes to this bug.