Bug 157387

Summary: JSContext Inspector: Better CommandLineAPI in JSContext inspection
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-05-05 14:11:01 PDT
* SUMMARY Better CommandLineAPI in JSContext inspection. * NOTES Much of the command line API doesn't apply to JSContexts, but some of it does and can be implemented: dir, clear, table, profile, profileEnd, keys, values The only thing this is really lacking is `copy(...)`.
Attachments
[PATCH] Proposed Fix (3.94 KB, patch)
2016-05-05 14:13 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (3.75 KB, patch)
2016-05-05 14:19 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-05-05 14:11:07 PDT
<rdar://problem/22630583>
Joseph Pecoraro
Comment 2 2016-05-05 14:13:32 PDT
Created attachment 278187 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-05-05 14:18:10 PDT
Comment on attachment 278187 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278187&action=review > Source/JavaScriptCore/inspector/InjectedScriptSource.js:1439 > + inspectedGlobalObject.console.warn("Before"); Hahah, I should not have these debug statements.
Joseph Pecoraro
Comment 4 2016-05-05 14:19:00 PDT
Created attachment 278188 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2016-05-05 15:11:20 PDT
Comment on attachment 278188 [details] [PATCH] Proposed Fix Clearing flags on attachment: 278188 Committed r200482: <http://trac.webkit.org/changeset/200482>
WebKit Commit Bot
Comment 6 2016-05-05 15:11:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.