Bug 157367

Summary: Add HLE locks and synchronic TTAS locks to the ToyLocks benchmark suite
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch benjamin: review+

Filip Pizlo
Reported 2016-05-04 17:13:32 PDT
Patch forthcoming.
Attachments
the patch (3.59 KB, patch)
2016-05-04 17:16 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-05-04 17:16:01 PDT
Created attachment 278145 [details] the patch
WebKit Commit Bot
Comment 2 2016-05-04 17:17:26 PDT
Attachment 278145 [details] did not pass style-queue: ERROR: Source/WTF/benchmarks/ToyLocks.h:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:116: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:117: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:121: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:125: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:117: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:121: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:125: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:127: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:130: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:134: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:130: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:134: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] Total errors found: 13 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2016-05-04 17:17:53 PDT
Landed in http://trac.webkit.org/changeset/200444
Note You need to log in before you can comment on or make changes to this bug.