Bug 157365

Summary:

Add a few more WTF locking benchmarks

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Web Template Framework

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	benjamin: review+

Description Filip Pizlo 2016-05-04 15:56:48 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2016-05-04 15:58:34 PDT

Created attachment 278137 [details]
the patch

Comment 2 WebKit Commit Bot 2016-05-04 15:59:38 PDT

Attachment 278137 [details] did not pass style-queue:


ERROR: Source/WTF/benchmarks/LockSpeedTest.cpp:95:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WTF/benchmarks/LockFairnessTest.cpp:74:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:35:  Do not use unnamed namespaces in header files.  See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information.  [build/namespaces] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:78:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2016-05-04 16:01:02 PDT

Landed in http://trac.webkit.org/changeset/200438