Bug 157316

Summary: Web Inspector: Simplify console.clear
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, keith_miller, mark.lam, msaboff, saam, timothy
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-05-03 11:15:53 PDT
* SUMMARY Miscellaneous console tweaks. - console.assert.length should be 1, it expects at least one argument - console.clear doesn't take any arguments, so clean up that path
Attachments
[PATCH] Proposed Fix (8.54 KB, patch)
2016-05-03 11:17 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (5.14 KB, patch)
2016-05-03 13:36 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-05-03 11:17:27 PDT
Created attachment 278009 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 2 2016-05-03 11:29:11 PDT
Comment on attachment 278009 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278009&action=review > LayoutTests/js/console.html:43 > + if (property === "assert") > + shouldBe(`console.${property}.length`, '1'); > + else > + shouldBe(`console.${property}.length`, '0'); I would expect them all to be 1. Hmm.
Joseph Pecoraro
Comment 3 2016-05-03 13:35:58 PDT
Retitling. I'm not changing assert here.
Joseph Pecoraro
Comment 4 2016-05-03 13:36:58 PDT
Created attachment 278014 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2016-05-03 18:54:02 PDT
Comment on attachment 278014 [details] [PATCH] Proposed Fix Clearing flags on attachment: 278014 Committed r200404: <http://trac.webkit.org/changeset/200404>
WebKit Commit Bot
Comment 6 2016-05-03 18:54:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.