Bug 157308

Summary: Rename JSKeyValueIterator as JSDOMIterator
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2016-05-03 05:21:21 PDT
With some improvements, JSKeyValueIterator may handle set iterators as well as map iterators. As a first step, it might be good to rename it as JSDOMIterator.
Attachments
Patch (19.90 KB, patch)
2016-05-03 05:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-05-03 05:23:23 PDT
Created attachment 277989 [details] Patch
WebKit Commit Bot
Comment 2 2016-05-03 17:28:28 PDT
Attachment 277989 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMIterator.h:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2016-05-04 01:21:41 PDT
Comment on attachment 277989 [details] Patch Clearing flags on attachment: 277989 Committed r200411: <http://trac.webkit.org/changeset/200411>
WebKit Commit Bot
Comment 4 2016-05-04 01:21:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.